Fix OpenAI completion args routing#1653
Open
kayametehan wants to merge 1 commit intoopenai:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1493 and #1504.
Overview
--completion_argscurrently breaks in two ways for OpenAI completion functions:OpenAIChatCompletionFnrejects extra kwargs such astemperatureOpenAICompletionFnaccepts extra kwargs but silently drops them instead of forwarding them to the API request optionsThere is also a related registry-plumbing issue where
registrycan be passed intoOpenAIChatCompletionFnwhen the class is referenced from the registry.What changed
OpenAIChatCompletionFnto accept extra kwargsextra_optionsfor both OpenAI completion function classes--completion_args, so values liketemperature=0.5andmax_tokens=10are parsed as numbers rather than stringsValidation
I verified this change before pushing with:
python -m pytest evals/completion_fns/openai_test.py evals/cli/oaieval_test.py -qpython -m pytest evals/registry_test.py evals/completion_fns/openai_test.py evals/cli/oaieval_test.py -qtemperatureandmax_tokensgit diff --check